haskell/haskell-ide-engine

Suggstion: ship with profiling disabled via stack-8.x.x.yaml

Open

#1,248 建立於 2019年5月8日

在 GitHub 查看
 (5 留言) (0 反應) (0 負責人)Haskell (2,358 star) (205 fork)batch import
Well Defined Task - Awaiting PRbuildgardening 🌱good first issue

描述

Related to #1214, which reports that building with profiling on under stack doesn't work.

Some developers may have profiling on by default with stack (i.e. library-profiling: true and executable-profiling: true in ~/.stack/config.yaml). I do this because I want profiling on more often than I want it off, and because it takes a long time to switch between profiling and non-profiling builds with stack. This configuration caused building HIE to fail and it took quite a while to figure out why.

As long as profiling doesn't work out of the box with stack, might it make sense ship with profiling explicitly disabled in stack-8.x.x.yaml?

build:
  library-profiling: false
  executable-profiling: false

貢獻者指南

技術棧
無
領域
build systemtooling
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic knowledge of Stack build toolUnderstanding of profiling flags
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Look at the file stack 8.x.x.yaml in the repository. The suggestion is to add build configuration options to disable profiling explicitly. Refer to the related issue #1214 for context on why profiling causes build failures. Check if there are any recent comments or updates on this issue to ensure the approach is still valid.