haskell/aeson

Add saner ByteString instances

Open

#187 建立於 2014年3月5日

在 GitHub 查看
 (22 留言) (3 反應) (0 負責人)Haskell (1,298 star) (334 fork)batch import
blocked by upstream/should be done externallyhelp wantedneeds decision

描述

ByteString instances were removed because they allowed people to try and insert arbitrary binary data that JSON can't handle.

Could we not re-add ByteString instances that leveraged something like base64 encoding (which JSON can take I believe) to work around this limitation?

<mgsloan> Fuuzetsu: Best thing to do is to avoid putting bytestrings in json,
          but when it's unavoidable:
          https://gist.github.com/mgsloan/bfe4bf2250c1d656a2b1  [05:03]

貢獻者指南

技術棧
無
領域
backenddata
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
3-5 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
HaskellByteStringJSONbase64
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
25
研究方向
Examine the linked gist (https://gist.github.com/mgsloan/bfe4bf2250c1d656a2b1) for a previous implementation of ByteString instances using base64. Review the aeson source code, particularly the Data.Aeson.Types and Data.Aeson.Encoding modules, to understand where instances are defined and how existing types handle custom encodings. Check the issue comments for any additional constraints or rejection reasons for the prior removed instances.