haskell-servant/servant

servant-client requires charset in Accept PlainText

Open

#1,002 建立於 2018年7月2日

在 GitHub 查看
 (7 留言) (1 反應) (0 負責人)Haskell (1,953 star) (422 fork)batch import
enhancementhelp wantednewcomer-friendlyservant-api

描述

The current implementation is

instance Accept PlainText where
    contentType _ = "text" M.// "plain" M./: ("charset", "utf-8")

Trying to parse text/plain yields UnsupportedContentType text/plain

One API I'm calling does not specify the charset so I can't use PlainText, but this does the job:

data PT
instance Accept PT where
  contentType _ = "text" M.// "plain"

The workaround is simple, but could/should the charset be made optional?

貢獻者指南

技術棧
無
領域
backendapi
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
needs maintainer response
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Haskell basicsservant library
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
The issue is about the Accept instance for PlainText requiring a charset parameter. The relevant code is likely in the servant client package, possibly in an Accept instance definition. The workaround shows a custom Accept instance without charset. The maintainers need to decide whether to make charset optional or accept both variants. Research the discussion comments and check if there is any linked PR or decision.
servant-client requires charset in Accept PlainText · haskell-servant/servant#1002 | Good First Issue