handshake-org/hsd

Improve test coverage

Open

#684 建立於 2022年1月11日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)JavaScript (1,814 star) (286 fork)batch import
Good first issuetests

描述

I noticed in the coverage report that a lot of the wallet make___() errors are not covered (eg "Auction is not yet open" and "Name has not reached bidding phase", etc). This could be another "good first issue" that would be easy to do and get a few more lines covered.

Originally posted by @pinheadmz in https://github.com/handshake-org/hsd/issues/683#issuecomment-1009248506

貢獻者指南

技術棧
javascript
領域
testing
議題類型
test
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Node.jsbasic testing knowledge
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
85
研究方向
The issue requests adding test coverage for wallet `make ()` error messages. Review the referenced comment in issue #683 for context. Locate the wallet module in the codebase, identify all error strings (e.g., 'Auction is not yet open'), and write unit tests that verify these errors are thrown correctly under relevant conditions.