hackjutsu/Lepton

Support 2-factor auth with security key

Open

#389 建立於 2019年11月24日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)JavaScript (9,902 star) (502 fork)batch import
help wanted

描述

The more we know about your system and use case, the more easily and likely we can help.

Environment info

  • OS: Windows 10
  • App Version (Command/Ctrl + ,): I just downloaded it and haven't logged in yet so I don't know!

Description of the problem / feature request / question:

I use a yubikey for 2 factor auth on github. After I click "Use security key" in the login dialog, nothing happens.

What should happen is that Windows prompts me for my security key...this is how it works through the github website.

If possible, provide a sample gist or screenshot:

fND2cyPSeR

貢獻者指南

技術棧
javascriptelectronnodejs
領域
desktopsecurity
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic knowledge of WebAuthnfamiliarity with Electron
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
Investigate the login flow in the Electron app, particularly the 'Use security key' button handler. Check the WebAuthn API calls in the main process. Look at existing authentication code and any libraries used for WebAuthn. Consider referencing WebAuthn specification and how GitHub's website handles it.