guardicore/monkey

Invalid configurations can be exported in the UI

Open

#3,703 建立於 2023年9月15日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)Python (752 fork)batch import
BugComplexity: MediumHelp wantedImpact: LowUI

倉庫指標

Star
 (6,250 star)
PR 合併指標
 (30 天內沒有已合併 PR)

描述

Describe the bug

While an invalid configuration can't be submitted through the UI, it can be exported.

Trying to import that configuration in the UI isn't allowed, so it could be frustrating for a user who didn't realise that some values were invalid while exporting.

To Reproduce

Steps to reproduce the behavior:

  1. Run Island
  2. Add invalid configuration value somewhere
  3. Try submitting and see warning box
  4. Export and check the exported configuration for invalid value

Expected behavior

Don't allow exporting configuration if some values are invalid.

Screenshots

  1. Added invalid IP to configuration image

  2. Export modal works normally, but a warning is shown on the configuration page image

  3. Warning box image

  4. Exported configuration image

貢獻者指南