guardicore/monkey

Unify modal window styles

Open

#1,002 建立於 2021年2月26日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)Python (6,250 star) (752 fork)batch import
Beginner friendlyComplexity: LowHelp wantedImpact: MediumUI

描述

Some modal windows have their style inlined in their JSX:

https://github.com/guardicore/monkey/blob/bc3283c4a5177c7d08ff65bb13370d061aae60d3/monkey/monkey_island/cc/ui/src/components/ui-components/IslandMonkeyRunErrorModal.js#L72-L82

https://github.com/guardicore/monkey/blob/bc3283c4a5177c7d08ff65bb13370d061aae60d3/monkey/monkey_island/cc/ui/src/components/pages/ConfigurePage.js#L178-L195

https://github.com/guardicore/monkey/blob/26dc2aeb146a50651a0df223d979a0fdf2161a5c/monkey/monkey_island/cc/ui/src/components/configuration-components/UnsafeOptionsConfirmationModal.js#L7-L27

Other modals, such as ImageModal and ScoutsuiteRuleModal have separate style sheets.

Unify the styles for all modal windows. Use style sheets instead of hardcoding style in the JSX

貢獻者指南

技術棧
javascriptreactcss
領域
frontend
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic React knowledgeCSS
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
Identify all modal components that have inline styles in JSX. Use the provided links as starting points (e.g., IslandMonkeyRunErrorModal.js, ConfigurePage.js, UnsafeOptionsConfirmationModal.js). Extract the inline styles and create CSS modules or stylesheets for each modal. Ensure the styles are consistent with existing modal stylesheets like those in ImageModal and ScoutsuiteRuleModal. Test by running the UI and verifying the modals display correctly.