br tags in headings · guardian/scribe#481

2016-06-07T12:51:13.000Z

It seems like ` ` in h1/h2/h3 etc. tags makes `document.execCommand('formatBlock', false, 'p')` function work not the way it have to. Way to reproduce bug at the demo-page: 1. create three ` `-paragraphs 2. select them 3. click h2-button, so you get ` Hello, World! Hello, World! Hello, World! ` 4. set caret after last ` ` and try to click h2-button again to remove h2 tag. It will not work. 5. If you wil set caret before ` ` and try to click h2, at first it will remove ` `-tag and after another click it will acts like it have to.

(1 留言) (0 反應) (0 負責人)JavaScript (3,516 star) (265 fork)batch import

bughelp wanted

描述

It seems like <br> in h1/h2/h3 etc. tags makes document.execCommand('formatBlock', false, 'p') function work not the way it have to.

Way to reproduce bug at the demo-page:

create three <p>-paragraphs
select them
click h2-button, so you get <h2>Hello, World!<br>Hello, World!<br>Hello, World!</h2>
set caret after last <br> and try to click h2-button again to remove h2 tag. It will not work.
If you wil set caret before <br> and try to click h2, at first it will remove <br>-tag and after another click it will acts like it have to.

貢獻者指南

技術棧: javascripthtml
領域: frontend
議題類型: bug
難度: 3
預計時間: 1-3 hours
活動狀態: stale
清晰度: mostly clear
前置要求: Understanding of execCommandKnowledge of HTML DOM manipulation
新手友善度: 30
研究方向: Investigate the scribe source code, particularly the implementation of formatBlock for headings. Check how the editor handles <br> elements inside headings during formatting toggling. Look at the specific commands that process selection and block formatting. The issue likely lies in the logic that removes heading tags when <br> is present. See files related to command execution and HTML normalization.