guardian/scribe

Make sure scribe markers are not left around

Open

#278 建立於 2014年10月24日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)JavaScript (3,516 star) (265 fork)batch import
beginnerhelp wanted

描述

Scribe markers are currently left all over the place. Look at this https://github.com/guardian/scribe/pull/248 for an example.

The approach here from @chanon is simple but should be merged as part of a separate pull request as checking the range was done in https://github.com/guardian/scribe/pull/273

貢獻者指南

技術棧
javascript
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
needs investigation
前置要求
basic understanding of Scribefamiliarity with DOM range
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
First, review the linked PR #248 to understand the approach suggested by chanon. Then, examine the current state of scribe markers in the source code, particularly in the relevant module (likely the selection or range handling). Check PR #273 for the range checking work that was done. The fix likely involves ensuring that when a selection or range is applied, any temporary markers are cleaned up. Since the repo is deprecated, consider if the issue is still relevant.
Make sure scribe markers are not left around · guardian/scribe#278 | Good First Issue