guardian/scribe

`underline` command is "enabled" when cursor is inside an <a> link

Open

#206 建立於 2014年6月20日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)JavaScript (3,516 star) (265 fork)batch import
browser inconsistencybughelp wantedpatch needed

描述

It seems like the default "underline" command checks the enabled CSS of the current selection, rather than looking for an explicit <u> element.

We were able to fix this locally easily by overriding the default "underline" queryState() command to look for an explicit <u> tag instead of relying on the default behavior.

貢獻者指南

技術棧
javascript
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic JavaScriptunderstanding of DOM events
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Examine the default underline command's `queryState()` method in Scribe's source code (likely in `underline.js` or similar). The issue indicates it checks CSS `enabled` instead of looking for an explicit `<u>` element. The fix involves overriding that method to detect `<u>` tags. Review the existing override pattern in the codebase to ensure consistency.
`underline` command is "enabled" when cursor is inside an <a> link · guardian/scribe#206 | Good First Issue