grpc-ecosystem/grpc-gateway

Possible regression when specifying duplicate paths

Open

#830 建立於 2018年12月12日

在 GitHub 查看
 (7 留言) (0 反應) (0 負責人)Go (16,971 star) (2,250 fork)batch import
bughelp wanted

描述

I haven't got a lot of time to debug this right now, but at work I've recently run into several instances of the generator not erroring when specifying duplicate paths, like so:

get: "/api/v1/users/{user_id}"
...
get: "/api/v1/users/things"

The second one should not be allowed because it is ambiguous with the first one. I'm pretty sure this used to work, so I assume it's a regression. I'm raising just so I don't forget about it. This is happening on latest master.

貢獻者指南

技術棧
gogrpcrest api
領域
backendapitooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Go programminggRPC basicsgrpc gateway codebase structure
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
45
研究方向
The issue is a regression: duplicate paths should trigger an error but do not. Examine the generator's route validation logic, likely in the `internal/descriptor` or `protoc gen grpc gateway` packages. Look for recent commits that might have removed the duplicate path check. Check the test files for any existing tests for duplicate paths. The maintainers may need to confirm the expected behavior.
Possible regression when specifying duplicate paths · grpc-ecosystem/grpc-gateway#830 | Good First Issue