grommet/grommet

Anchor - icon size

Open

#7,231 建立於 2024年5月14日

在 GitHub 查看
 (4 留言) (0 反應) (0 負責人)JavaScript (8,247 star) (1,015 fork)batch import
bughacktoberfesthelp wanted

描述

Expected Behavior

If the icon is not passed a size then the icon size should scale based on the Anchor size. Potentially related to the useSizedIcon function in Grommet.

Actual Behavior

The icon size does not scale with the Anchor size.

URL, screen shot, or Codepen exhibiting the issue

image

貢獻者指南

技術棧
javascriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
React basicsGrommet component structure
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Investigate the Anchor component source code in the Grommet repository, focusing on how icon size is currently handled and how the `useSizedIcon` function works. Check if there is a size prop inheritance mechanism from Anchor to its icon. The issue mentions that icon size should scale based on Anchor size when no icon size is specified. Look at the Anchor component file (likely in src/js/components/Anchor) and the useSizedIcon hook to understand the current logic and identify where the scaling behavior is missing.