gristlabs/grist-core

make limit on API request body size configurable

Open

#916 建立於 2024年3月27日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)TypeScript (3,613 star) (168 fork)batch import
good first issue

描述

There is a limit set on the maximum API request body size. That limit is currently hardcoded to 1mb (https://github.com/gristlabs/grist-help/pull/320#issuecomment-2021537352). It would be good to make this configurable, in the same way that related parameters like GRIST_MAX_UPLOAD_IMPORT_MB and GRIST_MAX_UPLOAD_ATTACHMENT_MB are.

貢獻者指南

技術棧
typescriptnodejs
領域
backend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
familiarity with TypeScriptbasic knowledge of Grist's configuration
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Look at the hardcoded limit referenced in the issue (https://github.com/gristlabs/grist help/pull/320#issuecomment 2021537352). Examine how similar parameters like GRIST MAX UPLOAD IMPORT MB and GRIST MAX UPLOAD ATTACHMENT MB are implemented and made configurable. The goal is to introduce a new environment variable (e.g., GRIST MAX REQUEST BODY MB) and replace the hardcoded value with a check that reads this variable, falling back to 1MB if not set.
make limit on API request body size configurable · gristlabs/grist-core#916 | Good First Issue