倉庫指標

Star: (30,564 star)
PR 合併指標: (平均合併 11天 15小時) (30 天內合併 47 個 PR)

描述

What

2025-10-14T14:28:08.000Z

# What - Move Sobek option parsing to the mapping layer. # Why - Separation of concerns. - Option parsing is only required by the mapping layer. - To simplify and make the code and tests easy to reason about. # Current options to move - [ ] `Frame` options - [ ] `ElementHandleBaseOptions` - [ ] `PageReloadOptions` - [x] `PageScreenshotOptions` - [x] `Locator` options - [x] `Size.Parse` - [x] #5687 - [x] #5302 - [x] #5560 # Example - In [this code](https://github.com/grafana/k6/blob/38b6e6e9f5ee9ed4cd0bc0d4dcd03f90a7095d27/internal/js/modules/k6/browser/browser/locator_mapping.go#L299-L317), the parsing happens in the mapping layer. # Related - This issue is a continuation of the epic issue #4219.

Move Sobek option parsing to the mapping layer.

Why

Separation of concerns.
Option parsing is only required by the mapping layer.
To simplify and make the code and tests easy to reason about.

Current options to move

Example

In this code, the parsing happens in the mapping layer.

This issue is a continuation of the epic issue #4219.

貢獻者指南

研究方向: 檢查映射層中現有的選項解析（例如 locator mapping.go），確定 Sobek 選項解析的位置。然後重構將這些解析函數移動到映射層，並確保更新相應的測試。
技術棧: go
領域: backend
議題類型: 重構
難度: 3
預計時間: 半天
活動狀態: 活躍
清晰度: 清晰
前置要求: GoGit
新手友善度: 50

倉庫指標

描述

What

Why

Current options to move

Example

Related

貢獻者指南

每天在信箱收到新鮮 Easy issues。