grafana/k6

Address jhump/protoreflect deprecations introduced by v1.17.0

開放

#4,035 建立於 2024年11月4日

 (4 則留言) (0 個反應) (1 位負責人)Go (1,537 個分叉)batch import
enhancementgood first issue

倉庫指標

星標
 (30,564 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

As we bumped our github.com/jhump/protoreflect/desc dependency to v0.17.0 we decided to postpone addressing the deprecations this specific version introduced.

Specifically:

  • github.com/jhump/protoreflect/desc is now considered deprecated.

This package is now deprecated. Though use of this package is still needed in order to use a handful of other packages in this repo, many usages should instead prefer the "google.golang.org/protobuf/reflect/protoreflect" package in the Protobuf runtime. In a v2 of this repo, this package will no longer be present.

  • github.com/jhump/protoreflect/desc/protoparse is now considered deprecated.

This package is now deprecated. Most usages should instead prefer the "github.com/bufbuild/protocompile" package. There are some behavioral differences that we hope to address with additional API and enhancements to protocompile. But the protoparse package here is just a veneer on top of protocompile and we plan to do as little maintenance as possible here. In a v2 of this repo, this package will no longer be present.

As a result we have a couple of //nolint:staticcheck comments ignoring those deprecations explicitly. Those can be found in the following files:

Definition of done

We have replaced the deprecated packages import with their more modern counterparts, and the nolint statements have been removed.

貢獻者指南