googlefonts/glyphsLib

Handle default layer with custom name

開放

#619 建立於 2020年8月17日

 (0 則留言) (1 個反應) (0 位負責人)Python (55 個分叉)github user discovery
enhancementhelp wanted

倉庫指標

星標
 (199 顆星)
PR 合併指標
 (30 天內沒有已合併 PR)

描述

https://unifiedfontobject.org/versions/ufo3/layercontents.plist/ says:

public.default

This layer name indicates that the default layer has no user defined name. It must not be used as the layer name for any directory other than the default glyphs directory.

GlyphLib assumes the default layer has no user defined name but that may not be the case. https://github.com/googlefonts/glyphsLib/blob/638cbddd00b2334410bab914d932bf673d6342ca/Lib/glyphsLib/builder/layers.py#L74 Instead it should check that the layer is font.layers.defaultLayer or that its name is font.layers.defaultLayer.name.

貢獻者指南