google/rejoiner

Schema Modification does not work on Input types

Open

#70 建立於 2019年2月27日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)Java (3,647 star) (152 fork)batch import
help wanted

描述

Hello,

We are trying to remove a field on an input by doing SchemaModification, but from this code it looks like proto modification only works on GraphQLObjectType instead of GraphQLInputObjectType:

https://github.com/google/rejoiner/blob/cedc123c18918d8c090543a4236ee344d2dbffeb/rejoiner/src/main/java/com/google/api/graphql/rejoiner/ProtoRegistry.java#L196-L206

Is there any chance we can add support for type modification on the input type?

貢獻者指南

技術棧
javagraphqlgrpc
領域
apibackend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaGraphQLgRPC
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
The issue points to ProtoRegistry.java lines 196-206 where only GraphQLObjectType is handled. To add support for Input types, one needs to modify the ProtoModification logic to also apply to GraphQLInputObjectType. Check the ProtoModification interface and how it's used for objects, then extend to input types. Look at the GraphQL schema generation code to understand how input types are built and registered.