google/leveldb

Make background thread stoppable

Open

#863 建立於 2020年12月18日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)C++ (39,075 star) (8,199 fork)batch import
enhancementhelp wanted

描述

Hi,

Current version of LevelDB has detached background thread that can't be stopped and each environment calls std::abort() in destructor. This behavior prevents using of LevelDB in plugin dlls that can be started and stopped when main application still runs.

I think it is better to allow background thread to finish tasks in queue and then exit, when environment is being destroyed. That will make database loadable and unloadable.

貢獻者指南

技術棧
cpp
領域
database
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
C++ threadingLevelDB environment API
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Investigate the current environment destructor and background thread implementation in LevelDB. Look at files such as util/env posix.cc and include/leveldb/env.h to understand how the background thread is created and managed. Identify where std::abort() is called and design a mechanism to allow the thread to finish its current tasks and exit gracefully when the environment is destroyed. Review any existing discussions in the issue comments for additional insights or constraints.