google/closure-compiler

Parse error for quoted export/import names

Open

#3,961 建立於 2022年6月20日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)Java (7,176 star) (1,197 fork)batch import
P3help wanted

描述

// e.mjs
const a = 'print me';
export { a as "dove" };

// i.mjs
import { "dove" as b } from './e.mjs';
console.log(b);

"dove" is the quoted name, and this code works (i.mjs prints print me).

Spec reference: ModuleExportName can be StringLiteral.

However, compiler can't parse that:

e.mjs:3:14: ERROR - [JSC_PARSE_ERROR] Parse error. 'identifier' expected
  3| export { a as "dove" };
                   ^

i.mjs:2:9: ERROR - [JSC_PARSE_ERROR] Parse error. '}' expected
  2| import { "dove" as b } from './e.mjs';
              ^

貢獻者指南

技術棧
javascriptjava
領域
tooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaScriptES modules syntaxclosure compiler parser
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
45
研究方向
The issue is a parse error for quoted export/import names (string literals) in ECMAScript modules. The compiler's parser likely needs to accept `StringLiteral` where `ModuleExportName` is expected. Look at the parser source code in the closure compiler repository, specifically around export and import parsing. Check the grammar rules and tokenizer to allow string literals in those positions. The specification references are already provided in the issue.