google/closure-compiler

String.fromCharCode optimization

Open

#3,606 建立於 2020年5月27日

在 GitHub 查看
 (10 留言) (0 反應) (0 負責人)Java (7,176 star) (1,197 fork)batch import
P4featgood first issue

描述

I used: https://closure-compiler.appspot.com/home

Input code: document.write(String.fromCharCode(115));

Expected output: document.write("s")

Actual output: document.write(String.fromCharCode(115));

I expected the String.fromCharCode function to be removed to just the resulting character.

貢獻者指南

技術棧
javascript
領域
performance
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaJavaScriptAST manipulationoptimization passes
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Investigate the existing peephole optimization passes in the Closure Compiler, particularly the 'PeepholeOptimizations' class that handles constant folding. Look for patterns where function calls with constant arguments are replaced with the result. For String.fromCharCode with a single numeric argument, the optimization should replace it with the corresponding character string. Check the existing tests in the 'test' directory for similar optimizations to understand the required test structure. Consider examining the 'ProcessClosurePrimitives' or 'ReplaceStrings' passes for relevant logic.