google/closure-compiler

Jasmine Externs are out of Date

Open

#3,045 建立於 2018年8月6日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)Java (7,176 star) (1,197 fork)batch import
Externshelp wanted

描述

I've found that many Closure externs are out of date for Jasmine. Specifically, I see:

  • Many custom matcher types are missing, including:
    • CustomMatcherFactories
    • MatchersUtil
    • CustomEqualityTester
    • CustomMatcher
  • Jasmine's pretty print utility is missing (jasmine.pp())
  • Most matcher functions (toBe(), toEqual(), etc.) accept an optional string to use as an error message if the expectation fails. This is also missing.
  • Likely others...

Without these types, custom matchers are basically impossible. Would be great to see these types updated.

See: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/jasmine/index.d.ts

貢獻者指南

技術棧
javascript
領域
testingdeveloper experience
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaScript basicsClosure compiler externsJasmine testing
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Study the existing Closure externs for Jasmine in the closure compiler repository (likely in the externs directory). Compare with the latest Jasmine version's API, using the DefinitelyTyped types/jasmine/index.d.ts as a reference. Identify missing types such as CustomMatcherFactories, MatchersUtil, CustomEqualityTester, CustomMatcher, jasmine.pp(), and the optional string parameter in matchers. Then add or update the externs file accordingly.