Polymer pass crashes when "properties" is not an object literal · google/closure-compiler#1950 | Good First Issue

(0 留言) (0 反應) (0 負責人)Java (1,197 fork)batch import

help wanted

倉庫指標

Star: (7,176 star)
PR 合併指標: (平均合併 3天 4小時) (30 天內合併 1 個 PR)

描述

https://closure-compiler-debugger.appspot.com/#input0%3DPolymer(%257B%250A%2520%2520is%253A%2520'x-y'%252C%250A%2520%2520properties%253A%2520(function()%2520%257B%250A%2520%2520%2520%2520return%2520%257B%257D%253B%250A%2520%2520%257D)()%252C%250A%257D)%26input1%26conformanceConfig%26externs%3Dvar%2520Polymer%2520%253D%2520function(obj)%2520%257B%257D%250Avar%2520PolymerElement%2520%253D%2520function(obj)%2520%257B%257D%26refasterjs-template%26includeDefaultExterns%3D1%26CHECK_SYMBOLS%3D1%26CHECK_TYPES%3D1%26CLOSURE_PASS%3D1%26LANG_IN_IS_ES6%3D1%26MISSING_PROPERTIES%3D1%26POLYMER_PASS%3D1%26PRESERVE_TYPE_ANNOTATIONS%3D1%26PRETTY_PRINT%3D1%26TRANSPILE%3D1

We don't want to allow this, I don't think. But we should report an error rather than crashing :)

貢獻者指南

研究方向: 在Closure Compiler中找到Polymer pass程式碼，並識別那些假設'properties'是物件字面量的程式碼路徑。修改它以處理非物件字面量的值，並拋出一個描述性錯誤而不是崩潰。
技術棧: java
領域: frontend
議題類型: 錯誤
難度: 2
預計時間: 1-3 小時
活動狀態: 活躍
清晰度: 清晰
前置要求: GitJava
新手友善度: 75