google/closure-compiler

Warn if a goog.scope alias uses a different name from the last part of the original name

Open

#1,283 建立於 2015年12月4日

在 GitHub 查看
 (5 留言) (0 反應) (0 負責人)Java (7,176 star) (1,197 fork)batch import
enhancementhelp wanted

描述

When creating a short alias for some.really.long.name.Foo the alias should almost certainly be Foo. If someone writes

goog.scope(function() {
var Bar = some.really.long.name.Foo;
});

it is surprising and a violation of the style guide. We could probably warn for this pretty easily in the ScopedAliases pass

貢獻者指南

技術棧
javajavascript
領域
tooling
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaClosure Compiler architectureScopedAliases pass
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Examine the ScopedAliases pass at src/com/google/javascript/jscomp/ScopedAliases.java. Add a check when an alias is defined via goog.scope that compares the alias name to the last part of the fully qualified name. If they differ, add a warning using the compiler's warning system. Consider existing similar warnings as reference. Test with appropriate unit tests.
Warn if a goog.scope alias uses a different name from the last part of the original name · google/closure-compiler#1283 | Good First Issue