master is broken on Android · google/benchmark#731

(3 留言) (0 反應) (0 負責人)C++ (7,968 star) (1,539 fork)batch import

bughelp wanted

描述

master version (I tested revision c9311a44e1280853632fe2472345dd04514a2f74) fails to build on Android, with the error:

/Users/marat/benchmark/src/sysinfo.cc:586:21: error: use of undeclared identifier 'getloadavg'
  const int nelem = getloadavg(res.data(), kMaxSamples);
                    ^
1 error generated.

Repro:

git clone https://github.com/google/benchmark.git
cd benchmark
mkdir build && cd build
cmake -DCMAKE_TOOLCHAIN_FILE=/path/to/android/ndk/build/cmake/android.toolchain.cmake -DBENCHMARK_ENABLE_TESTING=OFF ..
make

貢獻者指南

技術棧: cpp
領域: build system
議題類型: bug
難度: 3
預計時間: under 1 hour
活動狀態: stale
清晰度: clear
前置要求: C++Android NDKCMakecross compilation
新手友善度: 40
研究方向: Investigate the sysinfo.cc file around line 586. The error indicates getloadavg is not available on Android. Consider using a preprocessor directive to conditionally include this code only on platforms that support getloadavg, or implement an alternative for Android. Check the repository's existing platform detection macros. Also review comments in the issue for any suggested solutions.