google/benchmark

[FR] cc_libraries should use "includes", not "strip_include_prefix"

Open

#1,512 建立於 2022年11月16日

在 GitHub 查看
 (3 留言) (1 反應) (0 負責人)C++ (7,968 star) (1,539 fork)batch import
enhancementhelp wanted

描述

So that when users import google-benchmark, the headers are included as "system headers", instead of regular headers.

If this is not done, compilers will throw warnings at google-benchmark code, which users have no way to act upon. Users should be able to choose a highly restrictive set of warnings without having to fix them in google-benchmark.

Note that this pattern is already applied in the googletest repo.

貢獻者指南

技術棧
cpp
領域
build system
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
1
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
BazelC++ build
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
Look at the BUILD files in the repository, likely under `src/` or `test/`, to find where `cc library` is used with `strip include prefix`. Examine the googletest repository referenced in the issue to see how they use `includes` instead. Then modify the corresponding `cc library` rules to replace `strip include prefix` with `includes` to mark headers as system headers.