google-gemini/gemini-cli

test(a2a-server): migrate process.env to vi.stubEnv() per GEMINI.md conventions

Open

#19,826 建立於 2026年2月21日

在 GitHub 查看
 (8 留言) (0 反應) (1 負責人)TypeScript (103,992 star) (13,657 fork)batch import
Stalearea/platformgood first issuehelp wantedkind/bugkind/customer-issuepriority/p3status/bot-triaged

描述

Description

Per the testing conventions documented in GEMINI.md:

When testing code that depends on environment variables, use vi.stubEnv('NAME', 'value') in beforeEach and vi.unstubAllEnvs() in afterEach. Avoid modifying process.env directly as it can lead to test leakage and is less reliable.

Several test files in packages/a2a-server/ still use direct process.env manipulation:

  • src/commands/init.test.ts (1 direct assignment)
  • src/config/config.test.ts (~8 direct assignments/deletions)
  • src/http/app.test.ts (3 direct assignments/deletions)

Proposed fix

Replace all direct process.env writes and deletes with vi.stubEnv() / vi.unstubAllEnvs() following the pattern documented in GEMINI.md.

I'd be happy to submit a PR for this.

貢獻者指南

技術棧
typescriptvitest
領域
testingbackend
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
blocked
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
familiarity with GEMINI.md conventionsbasic understanding of Vitest
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
Replace direct process.env assignments and deletions in the three test files (init.test.ts, config.test.ts, app.test.ts) with vi.stubEnv() in beforeEach and vi.unstubAllEnvs() in afterEach. Follow the pattern documented in GEMINI.md. No additional code changes are required.