x/sys/plan9: function Exit causes build failure · golang/go#78506

(6 留言) (0 反應) (0 負責人)Go (133,883 star) (19,008 fork)batch import

BugReportNeedsInvestigationOS-Plan9help wanted

描述

package main

import "golang.org/x/sys/plan9"

func main() { plan9.Exit(0) }

This doesn't build

$ GOARCH=amd64 GOOS=plan9 go build
# test
golang.org/x/sys/plan9.exit: relocation target syscall.exit not defined

plan9.Exit calls plan9.exit, which is an assembly stub that jumps to syscall.exit. But there is no syscall.exit in the syscall package on Plan 9.

If the function is not needed (as it clearly doesn't work so nobody is using it), we probably can delete it. If it is needed for some reason, it could just call syscall.Exit, in Go code, not assembly.

cc @golang/plan9

貢獻者指南

技術棧: go
領域: backend
議題類型: bug
難度: 2
預計時間: under 1 hour
活動狀態: fresh
清晰度: clear
前置要求: Go programming knowledgebasic understanding of syscalls
新手友善度: 75
研究方向: The issue is a build failure in the plan9.Exit function. The function currently calls an assembly stub that jumps to syscall.exit, which doesn't exist on Plan 9. Two solutions are proposed: delete the function entirely or rewrite it to call syscall.Exit directly in Go code. To implement, locate the file containing the plan9.Exit function in the golang.org/x/sys/plan9 package. The assembly stub for exit may be in a .s file. The fix is straightforward: either remove the exit function and its assembly stub, or replace the assembly implementation with a Go function that calls syscall.Exit. No linked PRs or maintainer questions in the comments.