golang/go

x/tools/go/analysis/passes/modernize: minmax: suggest deletion of redundant min and max functions

Open

#75,589 建立於 2025年9月24日

在 GitHub 查看
 (13 留言) (1 反應) (0 負責人)Go (133,883 star) (19,008 fork)batch import
NeedsInvestigationRefactoringToolshelp wanted

描述

Proposal Details

I proposal to add a checker to check whether user has impl a max/min instead of builtin max/min. And suggest user to replace with builtin max/min. search

language:go "func min"

in github with get about 142k result in code.

貢獻者指南

技術棧
go
領域
toolingdeveloper experience
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
3-5 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
active
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Go programmingGo analysis frameworkAST manipulation
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
45
研究方向
Review the existing checkers in the modernize pass to understand the pattern for suggesting replacements. Analyze the Go AST for function declarations named 'min' or 'max' that have the same signature as built in min/max. Consider edge cases like different return types, variadic versions, or use in older Go versions. Check comments in the issue for any additional constraints or examples.