golang/go

x/tools/gopls/internal/analysis/modernize: add pass to use reflect.TypeAssert

Open

#75,422 建立於 2025年9月11日

在 GitHub 查看
 (5 留言) (0 反應) (0 負責人)Go (133,883 star) (19,008 fork)batch import
AnalysisFeatureRequestToolsgoplshelp wanted

描述

https://go.dev/cl/702735 replaced v.Interface().(T) with reflect.TypeAssert[T](v), where v is a reflect.Value, and demonstrated a significant performance improvement. Although the new code is 7 chars longer, it is more direct and arguably clearer. We should add a modernizer to automate this transformation when v.Interface().(T) appears in a two-value (x, ok := ...) context in a file using go1.25 or later. The doc comment for TypeAssert states that they are "semantically equivalent".

貢獻者指南

技術棧
go
領域
developer experiencetooling
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Go programminggopls internalsreflect package
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Study the existing modernizer passes in x/tools/gopls/internal/analysis/modernize to understand the pattern. Refer to CL 702735 for the implemented transformation. The task is to add a new pass that replaces `v.Interface().(T)` with `reflect.TypeAssert[T](v)` in two value contexts for files using Go 1.25+. Look at how other passes like `loopvar` or `slices` are structured to implement the new pass.