x/review/git-codereview: asks for password when cookie is required · golang/go#74689

(4 留言) (0 反應) (0 負責人)Go (133,883 star) (19,008 fork)batch import

NeedsFixToolProposalhelp wanted

描述

Go version

go1.24.1 darwin/arm64

Output of `go env` in your module/workspace:

AR='ar'
CC='clang'
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_ENABLED='1'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
CXX='clang++'
GCCGO='gccgo'
GO111MODULE=''
GOARCH='arm64'
GOARM64='v8.0'
GOAUTH='netrc'
GOBIN=''
GOCACHE='/Users/bracken/Library/Caches/go-build'
GOCACHEPROG=''
GODEBUG=''
GOENV='/Users/bracken/Library/Application Support/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFIPS140='off'
GOFLAGS=''
GOGCCFLAGS='-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/j6/l0vmp0f15cg2_0jz9zcm2jvh0000gn/T/go-build2342916578=/tmp/go-build -gno-record-gcc-switches -fno-common'
GOHOSTARCH='arm64'
GOHOSTOS='darwin'
GOINSECURE=''
GOMOD='/dev/null'
GOMODCACHE='/Users/bracken/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='darwin'
GOPATH='/Users/bracken'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/local/go'
GOSUMDB='sum.golang.org'
GOTELEMETRY='local'
GOTELEMETRYDIR='/Users/bracken/Library/Application Support/go/telemetry'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/go/pkg/tool/darwin_arm64'
GOVCS=''
GOVERSION='go1.24.1'
GOWORK=''
PKG_CONFIG='pkg-config'

What did you do?

I installed golang.org/x/review/git-codereview using the instructions at https://go.dev/doc/contribute#git-codereview_install because I was using a different machine to make changes to a review I had received feedback on.

What did you see happen?

git codereview mail prompted me for a username, and then for a password which doesn't exist.

What did you expect to see?

git codereview mail to either work or tell me what is wrong.

貢獻者指南

技術棧: go
領域: tooling
議題類型: bug
難度: 3
預計時間: half day
活動狀態: fresh
清晰度: mostly clear
前置要求: basic Go setupunderstanding of Gerrit authentication
新手友善度: 60
研究方向: Investigate how git codereview prompts for credentials. Check if the issue is related to missing cookie file or misconfigured GOAUTH. Look at the source code in the x/review repository for authentication handling. The user mentions they installed git codereview on a new machine; likely need to set up a Gerrit cookie. Consider adding documentation or detection for missing cookie.

描述