golang/go

x/tools/gopls: consider using &S form instead of *S for pointer type struct field autocompletion

開放

#39,227 建立於 2020年5月23日

 (5 則留言) (0 個反應) (0 位負責人)Go (19,008 個分叉)batch import
NeedsDecisionToolsgoplshelp wanted

倉庫指標

星標
 (133,883 顆星)
PR 合併指標
 (30 天內沒有已合併 PR)

描述

Currently autocompletion for a struct field uses the field's type as the placeholder text. For example,

type F struct {...}
type S struct {
   Field *F
}

The autocompletion for the Field will return "newText":"Field: ${1:*F},". gopls uses the type info for placeholder text, so I don't think the choice is incorrect nor invalid.

But if the suggestion used &F instead, it would be more convenient when users want to use composite literals. Especially, if the type name is long to type, reusing what's already in the placeholder will save many keystrokes.

(Based on https://github.com/golang/vscode-go/issues/85)

貢獻者指南