go-kit/kit

[metrics/cloudwatch] Feature request: ability to publish a sample of metrics for histograms

Open

#980 建立於 2020年5月7日

在 GitHub 查看
 (5 留言) (0 反應) (0 負責人)Go (27,422 star) (2,446 fork)batch import
enhancementhelp wanted

描述

The cloudwatch metrics exporter currently has support for publishing histograms as a set of metrics of the histogram quantiles (e.g. p50, p90, p95, p99).

What I would like to do, is have the ability to instead publish a random sample of the recorded histogram values and let CloudWatch do the bucketing. This is because I have multiple instances that I would like to publish the same metric for without labeling them with a label unique to the instance. If there are less than 150 observations (the max for an individual PutMetricsData request to AWS), they would all be sent.

I pushed some changes up to demonstrate what I mean: https://github.com/go-kit/kit/compare/master...jszwedko:metrics/cloudwatch/add-ability-to-publish-histogram-values?expand=1 . If you all are amenable to this change, I can continue implementing it and open a PR.

Thanks!

貢獻者指南

技術棧
go
領域
observabilitycloud
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Go programmingAWS CloudWatch knowledgego kit metrics libraryhistogram concepts
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Examine the linked branch at https://github.com/go kit/kit/compare/master...jszwedko:metrics/cloudwatch/add ability to publish histogram values?expand=1 to see the proposed implementation. Focus on the cloudwatch metrics exporter in the repository (path: metrics/cloudwatch). Understand how histograms are currently published as quantiles and how the suggested change allows publishing raw samples. Review the AWS CloudWatch PutMetricsData API limits (max 150 values per request) and consider how to handle cases with more observations. Check existing tests and documentation for the cloudwatch package to ensure new functionality aligns with the project's patterns.