go-kit/kit

support for istio distributed tracing

Open

#977 建立於 2020年4月26日

在 GitHub 查看
 (4 留言) (0 反應) (0 負責人)Go (27,422 star) (2,446 fork)batch import
enhancementhelp wanted

描述

Hi guys,

I've been using go-kit for some times now (high five for the amazing work !) and have been developing micro-services on Kubernetes and istio where istio tracing is leveraged. If interested in supporting istio tracing through simple header propagation (istio doc), I have working code that I would be happy to push through a pull request.

Basically the code implements the function func ServerBefore(before ...RequestFunc) ServerOption for HTTP and gRPC

defined here

so that header values can be saved in the context, and then inject to every downstream requests.

Is it something you see being pushed to your code base ? Let me know. Cheers

貢獻者指南

技術棧
go
領域
observabilitybackend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Gogo kit basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
The issue proposes adding Istio distributed tracing support via header propagation. The author has working code but asks for maintainer interest. The relevant files are transport/http/server.go and transport/grpc/server.go. To contribute, review the existing code, integrate the header propagation logic, and add tests. Ensure compatibility with the existing context based middleware patterns in go kit.
support for istio distributed tracing · go-kit/kit#977 | Good First Issue