go-kit/kit

SD - Registrator error handling

Open

#780 建立於 2018年10月23日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)Go (27,422 star) (2,446 fork)batch import
enhancementhelp wantednewbie friendly

描述

Is there any reason for not returning any error on the registration of a service? https://github.com/go-kit/kit/blob/ec0cc13a9b00d1214c9b7ae63d7b750626b54c6d/sd/registrar.go#L11

From my point of view, if a service doesn't manage to correctly register, then it might be nice to retry later. Binding to events to watch if you're correctly registered seems overkilled compared to just checking this error.

What are your thoughts?

貢獻者指南

技術棧
go
領域
backend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Go programmingService discovery concepts
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Investigate the `Register` method in `sd/registrar.go` (line 11) and all implementations of the `Registrator` interface. The issue suggests adding an error return. Determine if any existing implementations already have error handling logic that could be lifted. Also consider the single comment on the issue for additional context. Write a test case for the new behavior.