go-kit/kit

Please, add proper attribution to log/term/*

Open

#640 建立於 2017年12月11日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)Go (27,422 star) (2,446 fork)batch import
enhancementhelp wanted

描述

Hi,

While preparing a Debian package for go-kit, the FTP masters rejected my package because of missing attribution in log/term/*

I checked the code and it seems it is deriving from ssh/terminal (although I don't see much code coming from there) and from github.com/mattn/go-colorable. There is a LICENSE file, which does not attribute properly either work, nor their original licenses (the Go license is BSD, not MIT), and attributes code to one Simon Eskildsen, who's not mentioned anywhere else.

All in all, copyright and licensing is very unclear in that directory. Could you please clarify it?

Thanks!

貢獻者指南

技術棧
go
領域
documentation
議題類型
documentation
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
basic understanding of open source licensing
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Examine the files in log/term/ and the existing LICENSE file. Identify the original sources (ssh/terminal from Go's standard library and github.com/mattn/go colorable) and their licenses. Add proper attribution to the LICENSE file, including the BSD license for the Go code and the MIT license for go colorable, ensuring compliance with their terms. Also, clarify the mention of Simon Eskildsen if necessary.