globalizejs/globalize

Date: Handle undefined skeleton

Open

#469 建立於 2015年7月23日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)JavaScript (4,759 star) (645 fork)batch import
date modulehelp wantedquick change

描述

When using an undefined skeleton, e.g., {skeleton: '<anything here that doesn't exist>'} https://github.com/jquery/globalize/blob/master/src/date.js#L64 returns undefined, which in turn is passed as the expanded-pattern to the formatter, which in turn tries to recognize u and fails.

Originally raised on #455.

貢獻者指南

技術棧
javascript
領域
localizationinternationalization
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
familiarity with JavaScriptunderstanding of date formatting
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
The issue is in the Date module of the Globalize library. The bug occurs at src/date.js line 64 when an undefined skeleton is passed. The value `undefined` is passed to the formatter, causing a failure. A fix would involve adding a check for undefined before using the skeleton. Refer to the original issue #455 for more context. The repository is a JavaScript project for internationalization using CLDR data.
Date: Handle undefined skeleton · globalizejs/globalize#469 | Good First Issue