globalizejs/globalize

Build: check built files don't contain external dependencies

Open

#371 建立於 2014年12月19日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)JavaScript (4,759 star) (645 fork)batch import
help wanted

描述

We just dealt with failures in functional tests that turned out to be caused by cldr/supplemental being added as a dependecy in one place, but not properly included in the build in a different place (requirejs build configuration, exclude option).

To make it easier to spot this kind of issue, we should write a build task that looks at files built in dist/ and throws an error if any file contains the Cldrjs library, or any other always-excluded dependency.

貢獻者指南

技術棧
javascript
領域
build systemdeveloper experience
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaScriptRequireJSNode.js
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
75
研究方向
Examine the existing build configuration (likely a Gruntfile or similar) to understand the current build process. The task should parse files in the dist/ directory and throw an error if any file contains a regex pattern matching 'cldrjs' or other excluded dependencies. Consider adding a new Grunt task or npm script.