globalizejs/globalize

Code cleanup: Simplify tests util functions that passes assert as a parameter

Open

#359 建立於 2014年12月8日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)JavaScript (645 fork)batch import
help wantedquick change

倉庫指標

Star
 (4,759 star)
PR 合併指標
 (30 天內沒有已合併 PR)

描述

Ref: https://github.com/jquery/globalize/pull/351/files#r21450909


util.assertParameterPresence( assert, "currency", function() {
  Globalize.currencyFormatter();
});

@jzaefferer

I brought this up before, might be worth another try. Can this be changed to the below?

assert.parameterPresence( "currency", ... );

The same applies to any other calls that pass assert as a parameter

@rxaviers

Sorry if I missed it. But, I don't remember such comment. If you say it's better overloading assert, it shall be. Will be tracked as a separate issue #359

貢獻者指南