glideapps/quicktype

Split up tests with huge objects

Open

#559 建立於 2018年2月17日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)TypeScript (10,867 star) (968 fork)batch import
CIgood first issue

描述

We have a few tests, in particular blns-object, keywords.json, and keyword-unions.schema, which have huge objects and slow down a few languages, particularly Rust. The objects don't need to be big - they're only testing that the keys in the objects work, so we can easily split them up without losing the benefit of the tests.

貢獻者指南

技術棧
typescript
領域
testing
議題類型
test
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Familiarity with quicktype's test structureUnderstanding of JSON Schema test files
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
The issue identifies three test files: blns object, keywords.json, and keyword unions.schema. The goal is to split the large objects in these files into smaller, focused tests. Review the current test structure in the repository, particularly how tests are organized and run. Then create separate test cases for each key or group of keys, ensuring the same coverage is maintained without the large objects. No linked PRs or comments are available for guidance.