gitpoint/git-point

Replace deprecated React lifecycle methods

Open

#887 建立於 2019年8月27日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)JavaScript (4,684 star) (837 fork)batch import
help wanted

描述

As suggested in https://github.com/gitpoint/git-point/pull/862#issuecomment-524167180, and more potential problems can be discovered by StrictMode.

  • componentWillMount
    • user/screens/starred-repository-list.screen.js
  • componentWillReceiveProps
    • auth/screens/events.screen.js
    • auth/screens/language-setting.screen.js
    • auth/screens/user-options.screen.js
    • notifications/screens/notifications.screen.js
    • organization/screens/organization-profile.screen.js
  • componentWillUpdate
    • None

貢獻者指南

技術棧
javascriptreactreact native
領域
mobilefrontend
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
React lifecycle methodsReact Native basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
85
研究方向
Review the linked PR comment (https://github.com/gitpoint/git point/pull/862#issuecomment 524167180) and React StrictMode documentation. For each file in the checklist, examine the usage of deprecated lifecycle methods and plan replacements with appropriate modern alternatives (e.g., getDerivedStateFromProps, componentDidUpdate). Consider potential side effects and test after changes.
Replace deprecated React lifecycle methods · gitpoint/git-point#887 | Good First Issue