Icons and the sort of issue events · gitpoint/git-point#868

2019-01-23T13:56:56.000Z

- Not every icon is in the center. - We need test function `marginLeftForIconName` in `issue-event-list-item.component.js` for every icons and update. - The sort doesn't always obey created time. Maybe caused by #848. - Some items have invalid `created_at` value.

(0 留言) (0 反應) (0 負責人)JavaScript (4,684 star) (837 fork)batch import

:bug: bughelp wanted

描述

Not every icon is in the center.
- We need test function marginLeftForIconName in issue-event-list-item.component.js for every icons and update.
The sort doesn't always obey created time. Maybe caused by #848.
- Some items have invalid created_at value.

貢獻者指南

技術棧: javascriptreact native
領域: frontendmobiletesting
議題類型: bug
難度: 3
預計時間: 1-3 hours
活動狀態: stale
清晰度: mostly clear
前置要求: React NativeJavaScriptGitPoint codebase
新手友善度: 40
研究方向: First, examine `issue event list item.component.js` to find the `marginLeftForIconName` function and ensure it correctly centers all icons. Write a test for it. Second, investigate the sorting logic in the same component or related files; check the `created at` values from the API and ensure they are valid timestamps. The issue mentions PR #848 may have caused the sorting problem, so review that PR's changes to understand the impact. Finally, verify that the sorting order respects chronological order.