gitbucket/gitbucket

Creating pull request via web API returns escaped response

Open

#2,306 建立於 2019年4月30日

在 GitHub 查看
 (6 留言) (0 反應) (0 負責人)Scala (9,371 star) (1,262 fork)batch import
bughelp wanted

描述

Issue

Impacted version: 4.31.2

Deployment mode: standalone app

Problem description: When you create a pull request via web api, you'll get following response with double quotes escaped.

POST http://localhost:8080/api/v3/repos/root/test1/pulls HTTP/1.1
Content-Type: application/json

{
  "title": "Amazing new feature",
  "body": "Please pull this in!",
  "head": "develop",
  "base": "master"
}

"{\"number\":32,\"state\":\"open\",\"updated_at\":\"2019-04-30T05:39:30Z\",...

In case of the same API in GitHub

{"url":"https://api.github.com/repos/SIkebe/test1/pulls/2","id":274604732,...

貢獻者指南

技術棧
scalarest api
領域
backendapi
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ScalaREST APIJSON serialization
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
The bug is in the response of the create pull request API endpoint. Look in the API controllers under src/main/scala/gitbucket/core/api. The issue is that the JSON response is being double escaped, likely due to incorrect serialization. Check the method that constructs the PullRequest response and ensure the JSON is not escaped. Compare with how GitHub returns the response. Write a test to verify the fix.