ggml-org/whisper.cpp

max-len as a range or 'suggestion' to reduce dangling tokens

Open

#543 建立於 2023年2月27日

在 GitHub 查看
 (1 留言) (2 反應) (0 負責人)C++ (49,693 star) (5,535 fork)batch import
enhancementgood first issue

描述

suggestion that the max-len argument allow for some ambiguity of +- words/tokens or a nargs range instead of a hard int, so that the output files don't dangle a single word/token on successive timestamps.

Ex: Given the following output, it would probably be preferrable that the 2nd and 5th timestamp (there/job) would appear with the previous timestamp, possibly hard-wrapped to a second line in the cue, rather than alone.

` [00:06:23.160 --> 00:06:27.000] The other district where Pat was over

[00:06:27.000 --> 00:06:27.000] there,

[00:06:27.000 --> 00:06:28.380] also they know her.

[00:06:28.380 --> 00:06:31.680] So I think they were doing a very good

[00:06:31.680 --> 00:06:32.400] job.

[00:06:32.400 --> 00:06:35.750] - So only those two candidates were the

[00:06:35.750 --> 00:06:36.160] only ones `

貢獻者指南

技術棧
cpp
領域
backendcli
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Familiarity with C++Understanding of whisper.cpp command line parsing
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
First, examine how the max len argument is currently parsed and applied in main.cpp. The issue suggests allowing a range or tolerance (e.g., an integer with a +/ value). Look at the argument parsing code, likely using argparse or similar. Then, modify the logic to accept a range and adjust the output formatting to avoid dangling single words. The comment in the issue provides example output showing the problem; use that to test the change.