ggml-org/llama.cpp

llama : integer type consistency in `llama.h`

開放

#4,574 建立於 2023年12月21日

 (4 則留言) (4 個反應) (0 位負責人)C++ (21,737 個分叉)batch import
enhancementgood first issuerefactoringroadmap

倉庫指標

星標
 (124,043 顆星)
PR 合併指標
 (平均合併 6天 8小時) (30 天內合併 389 個 PR)

描述

Feature Description

llama.h should prefer to use sized (always) + signed (mostly) integers.

Motivation

The integer types in llama.h right now are.

Count Type
33 int
10 int32_t
24 uint32_t
2 int64_t
2 uint64_t

In #4540 there was a discussion around preferences for integer types on new methods.

Avoiding int makes cross platform code simpler at essentially no cost. Signed makes arithmetic simpler at the cost of some bits if you need something large.

Possible Implementation

  1. Change all int's to int32_t
  2. As code changes try to prefer signed integers.

We could also do some higher-impact things, but I'd take the lower-impact slower changes over a large find-and-replace.

貢獻者指南