getredash/redash

Google Spreadsheets worksheet by title cleanup/refactor

Open

#6,409 建立於 2023年8月31日

在 GitHub 查看
 (5 留言) (3 反應) (1 負責人)Python (24,845 star) (4,236 fork)batch import
enhancementgood first issue

描述

In #5334 , I left a few comments about future work on the "fetch worksheet by title" functionality for the google spreadsheets query runner. We should address those, namely:

  • don't use mixed-type variables
  • allow for non-quoted worksheet titles (single word)
  • verify 0/1 indexing of worksheet numbers, and add comment if it differs

貢獻者指南

技術棧
python
領域
backendapi
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic Python knowledgeFamiliarity with Redash plugin structure
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Review the comments and code changes in PR #5334 to understand the existing implementation for fetching worksheet by title. Check the mixed type variables and decide on a consistent type. Look at how worksheet titles are currently quoted; extend support for non quoted single word titles. Verify the 0/1 indexing of worksheet numbers by examining the Google Sheets API documentation and the current usage in the codebase, then add clarifying comments.