getredash/redash

Query editor: format query feature breaks syntax of Postgres JSON operator

Open

#5,644 建立於 2021年11月8日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)Python (24,845 star) (4,236 fork)batch import
help wanted

描述

Issue Summary

Query editor: format query feature breaks syntax of Postgres JSON operator

Steps to Reproduce

  1. WHERE keywords @> '[{"keyword":{"id":12345}}]'
  2. Valid according to: https://www.postgresql.org/docs/12/functions-json.html
  3. Gets formatted as keywords @ > '[{"keyword":{"id":12345}}]'
  4. This is invalid syntax because the @ and > have become separated

Technical details:

  • Redash Version: 10.0.0-beta (92e5d78d)

貢獻者指南

技術棧
javascriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Familiarity with Redash query editor
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Investigate the query formatting logic in the Redash frontend. Look for a SQL formatter function that tokenizes operators. The issue is that `@>` is being split into two tokens. Check if there is a list of operators that needs to include `@>` as a single token. Relevant code is likely in the client directory, possibly in a file like 'QueryEditor.jsx'. Review any existing tests for the formatter.