getredash/redash

Add `hd` parameter for optimized Google Apps login

Open

#1,924 建立於 2017年8月9日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)Python (24,845 star) (4,236 fork)batch import
Backendenhancementhelp wanted

描述

https://github.com/getredash/redash/blob/53268989c5fe5c619b399b488094c501cb286af4/redash/authentication/google_oauth.py#L91

Would it be possible to add the hd parameter to this authorization URL in the event that there's a single allowed Google Apps domain? It optimizes the sign in experience by limiting the suggested accounts to those for the passed Google domain.

If you're signed in to a single account on the domain and already authorized Redash: instant redirect to login.

If you're signed in on the domain and haven't authorized Redash: present only accounts from the authorized Google domain.

If you're not signed in: present the login dialog with your domain pre-filled.

If you're interested in merging something like this but can't prioritize this as a feature I can put together a PR with the changes required.

貢獻者指南

技術棧
python
領域
authentication
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
OAuth 2.0 knowledgePython basicsRedash codebase familiarity
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
The issue requests adding the 'hd' parameter to the Google OAuth authorization URL in redash/authentication/google oauth.py at line 91. The implementation should check for a configured Google Apps domain and append the hd query parameter. Review existing OAuth flow and configuration settings to add a new setting for the allowed domain. No linked PRs or comments indicate ongoing work.