getredash/redash

Allow name and email for user added by Remote User Auth to be different

開放

#1,648 建立於 2017年3月2日

 (3 則留言) (0 個反應) (0 位負責人)Python (4,236 個分叉)batch import
Backendenhancementhelp wanted

倉庫指標

星標
 (24,845 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

Issue Summary

I'm trying to use Active Directory LDAP through remote_user_auth module. Currently there is no way to set different redash user name from mail address. So now my redash user accounts have mail address for both name and mail. Also, if user logs in with just the username or username@domain, the mail address is not correct and the alarm mail won't work.

Technical details:

To solve this, I guess we have to add another environment variable besides REMOTE_USER_HEADER.

Does it make sense to you to add variable like REMOTE_MAIL_HEADER, and use it like

name = REMOTE_USER_HEADER
email = REMOTE_MAIL_HEADER || REMOTE_USER_HEADER
create_and_login_user(current_org, name, email)

instead of

email = REMOTE_USER_HEADER
create_and_login_user(current_org, email, email)
  • Redash Version:Current Head
  • Browser/OS:Chrome
  • How did you install Redash:Docker

貢獻者指南