gajus/eslint-plugin-flowtype

require-return-type with { 'annotateUndefined': 'always' } should not trigger for class constructors

Open

#449 建立於 2020年6月29日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)JavaScript (1,078 star) (167 fork)batch import
bughelp wanted

描述

require-return-type with { 'annotateUndefined': 'always' } should not trigger for class constructors, since class constructors should never return anything.

貢獻者指南

技術棧
javascript
領域
tooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ESLint plugin developmentFlow type system basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Look at the `require return type` rule implementation, likely in `src/rules/requireReturnType.js`. The issue is that when `annotateUndefined` is set to 'always', the rule incorrectly flags class constructors. The fix involves adding an exception to skip constructors. Check the rule's logic for detecting constructor context (e.g., checking if the parent node is a class method with `kind` equal to 'constructor'). There are no existing comments or PRs on this issue, so it is unclaimed.
require-return-type with { 'annotateUndefined': 'always' } should not trigger for class constructors · gajus/eslint-plugin-flowtype#449 | Good First Issue