frintjs/frint

frint-react: Empty Component when Region is empty

Open

#216 建立於 2017年6月2日

在 GitHub 查看
 (3 留言) (1 反應) (0 負責人)JavaScript (746 star) (37 fork)batch import
featuregood first issuehelp wantedminor

描述

Current situation

Right now, when a Region has no Apps to render, it just remains empty.

It would be useful if we can pass some default Component to render in those cases.

Proposed API

import EmptyRegionContent from '../components/EmptyRegionContent';

<Region name="sidebar" empty={EmptyRegionContent} />

If the sidebar region is empty, it would render EmptyRegionContent component by default.

貢獻者指南

技術棧
javascriptreact
領域
frontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Reactfrint basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Look into the Region component in the frint react package. Understand how it currently renders apps. Implement an 'empty' prop that accepts a React component and renders it when no apps are provided. Ensure to add unit tests for the new functionality. Check if there are any existing TypeScript definitions that need updating.
frint-react: Empty Component when Region is empty · frintjs/frint#216 | Good First Issue